Web lists-archives.com

Re: [PATCH v7 7/8] blame: add a fingerprint heuristic to match ignored lines




Barret Rhoden <brho@xxxxxxxxxx> writes:

> From: Michael Platings <michael@xxxxxxxxx>
>
> +test_expect_success setup '
> +	{ for ((i=2;i<=$last_test;i++))

Crap.

What language are you writing this in?

Please make it a habit to try running the test suite with a shell
that is *not* bash, after you are happy with your tests in bash, e.g.

	$ make SHELL_PATH=/bin/dash test

Thanks.

> +	do
> +		# Append each line in a separate commit to make it easy to
> +		# check which original line the blame output relates to.
> +
> +		line_count=0 &&
> +		{ while IFS= read line
> +		do
> +			line_count=$((line_count+1)) &&
> +			echo "$line" >>"$i" &&
> +			git add "$i" &&
> +			test_tick &&
> +			GIT_AUTHOR_NAME="$line_count" git commit -m "$line_count"
> +		done } <"a$i"
> +	done } &&