Re: Closing fds twice when using remote helpers
- Date: Thu, 16 May 2019 09:31:30 +0900
- From: Mike Hommey <mh@xxxxxxxxxxxx>
- Subject: Re: Closing fds twice when using remote helpers
On Wed, May 15, 2019 at 07:56:09PM +0900, Mike Hommey wrote:
> I started getting a weird error message during some test case involving
> git-cinnabar, which is a remote-helper to access mercurial
> The error says:
> fatal: mmap failed: Bad file descriptor
> ... which was not making much sense. Some debugging later, and it turns
> out this is what happens:
> - start_command is called for fast-import
> - start_command is called again for git-remote-hg, passing the
> fast_import->out as cmd->in.
My mistake, it's the opposite: start_command for fast-import is called
with the out of git-remote-hg as in.
Anyways, patches incoming.