Web lists-archives.com

Re: [PATCH v2] status: add an empty line when there is no hint




林自均 <johnlinp@xxxxxxxxx> writes:

> I was not talking about the messages in the editor session. I was
> talking about "git commit" without "git add" anything.
>
> For example:
>
> ```
> $ touch newfile.txt
> $ git commit
> On branch master
> Untracked files:
>         newfile.txt
>
> nothing added to commit but untracked files present
> ```
>
> My current patch is trying to add an empty line between
> "Untracked files:" and "newfile.txt".

I do not think that one is paged, so if you ask me, I'd say we
shouldn't add an extra blank there.  Is that message also reused in
the editor session, or do two different codepaths produce a similar
looking message, one for the above case direct to the terminal and
the other for the editor session?

But again...

>> At the same time, I think I've been happy enough with the current
>> output from both commands, so if you let me bikeshed freely, I'd
>> probably pick "let's not change anything then" ;-)