Re: [PATCH v3 0/5] Fix and extend encoding handling in fast export/import
- Date: Mon, 13 May 2019 12:14:59 +0200 (CEST)
- From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
- Subject: Re: [PATCH v3 0/5] Fix and extend encoding handling in fast export/import
Hi Elijah,
On Fri, 10 May 2019, Elijah Newren wrote:
> * Modified the testcases to pass on Windows[1], as verified via
> gitgitgadget pull request[2]. Required adding a couple new files
> (which store the desired bytes) and checking the size of the output
> instead of checking for particular bytes (but the lengths of the
> expected byte sequences differ so this works fine...).
>
> [1] Failures of previous patchset on Windows noticed and reported by Dscho;
> explanation from Hannes is that Windows munges users' command lines to
> force them to be characters instead of bytes.
> [2] https://github.com/gitgitgadget/git/pull/187
Excellent! Thank you!
Ciao,
Dscho