Web lists-archives.com

Re: [PATCH v2] t4253-am-keep-cr-dos: avoid using pipes




Hi Junio,

Understood. Thanks for the clarification.

Best regards,
Boxuan Li

On Wed, May 8, 2019 at 1:49 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> "LI, BO XUAN" <liboxuan@xxxxxxxxxxxxxx> writes:
>
> > Thanks for your review! I can understand your point, but I've got a
> > quick question:
> >
> > What if format-patch really breaks and 'am' magically does not break?
>
> Doesn't that indicate that you are not testing the result of "am"
> adequately?
>
> I am not saying it is *wrong* to split the pipe into two.  I am
> merely saying that it is borderline Meh, as the primary point of
> these two tests are to see how the command downstream of the pipe
> behaves and not the upstream one.