Re: [PATCH 1/2] midx: pass a repository pointer
- Date: Wed, 8 May 2019 10:22:08 -0400
- From: Derrick Stolee <stolee@xxxxxxxxx>
- Subject: Re: [PATCH 1/2] midx: pass a repository pointer
On 5/7/2019 4:31 AM, Junio C Hamano wrote:
> "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>> From: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
>> Much of the multi-pack-index code focuses on the multi_pack_index
>> struct, and so we only pass a pointer to the current one. However,
>> we will insert a dependency on the packed_git linked list in a
>> future change, so we will need a repository reference. Inserting
>> these parameters is a significant enough change to split out.
>> Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
> This is a good move in the loger term, but not a happy thing to do
> while your "expire" topic is still in flight, as the impact from
> updating the signature of prepare_midx_pack() and friends will break
> new callers in expire_midx_packs() etc.
> I am tempted to queue this and eject ds/midx-expire-repack for now,
> while checking how that topic would look like when rebased on top of
> these two patches. We'll see.
Sorry for the noise. I consider this series a higher priority, as it
fixes a problem with the feature in existing releases.