Re: [PATCH] t4253-am-keep-cr-dos: avoid using pipes
- Date: Sun, 5 May 2019 02:32:19 -0400
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH] t4253-am-keep-cr-dos: avoid using pipes
On Sat, May 4, 2019 at 10:39 PM Boxuan Li <liboxuan@xxxxxxxxxxxxxx> wrote:
> The exit code of the upstream in a pipe is ignored thus we should avoid
> using it. By writing out the output of the git command to a file, we can
> test the exit codes of both the commands.
> Signed-off-by: Boxuan Li <liboxuan@xxxxxxxxxxxxxx>
> diff --git a/t/t4253-am-keep-cr-dos.sh b/t/t4253-am-keep-cr-dos.sh
> @@ -51,14 +51,16 @@ test_expect_success 'am with dos files without --keep-cr' '
> test_expect_success 'am with dos files with --keep-cr' '
> git checkout -b dosfiles-keep-cr initial &&
> - git format-patch -k --stdout initial..master | git am --keep-cr -k -3 &&
> + git format-patch -k --stdout initial..master > actual &&
> + git am --keep-cr -k -3 actual &&
Style nit: In this codebase, the space is omitted after the
redirection operator (i.e. >actual).
Nit: Given that the name "actual" is typically used in conjunction
with an "expect" (or "expected") file, its use here is somewhat
unexpected. Other possible names which might be more meaningful
include "patches" and "output".
> git diff --exit-code master