Web lists-archives.com

[no subject]




Bcc: 
Subject: Re: [PATCH 2/2] diffcore-pickaxe: add --pickaxe-raw-diff for use
 with -G
Reply-To: 
In-Reply-To: <20190503031531.GA19436@xxxxxxxxxxxxxxxxxxxxx>

On Thu, May 02, 2019 at 11:15:31PM -0400, Jeff King wrote:
> On Thu, Apr 25, 2019 at 02:54:48AM +0200, Eugeniu Rosca wrote:
> 
> > > This is unrelated to --pickaxe-raw-diff, -U<n> just implies -p in
> > > general. See e.g. "git log -U1".
> > 
> > Oops. Since I use `-U<n>` mostly with `git show`, I missed the
> > implication. You are right. Then, my question is how users are
> > going to (quote from commit description):
> > 
> > > >> > [..] search [..] through an arbitrary amount of
> > > >> > context lines when combined with -U<n>.
> > 
> > and achieve a `git log --oneline` report, given that -U<n> unfolds
> > the commits?
> 
> You can use "-s" to suppress patch output; as long as it comes after -U
> on the command-line, it will countermand the patch-format part.

That's a handy trick. Now the feature is really usable. Thanks.

> 
> (Of course it doesn't matter until we have a raw-diff grep, since
> otherwise the context lines do not matter at all, and you should just
> omit -U entirely).

Yep. Agreed.

> 
> -Peff

-- 
Best Regards,
Eugeniu.