Re: [PATCH 1/1] credential: do not mask the username
- Date: Mon, 29 Apr 2019 18:12:54 -0400
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH 1/1] credential: do not mask the username
On Mon, Apr 29, 2019 at 6:06 PM Jarosław Honkis via GitGitGadget
> When a user is asked for credentials there is no need to mask the
> username, so the PROMPT_ASKPASS flag on calling credential_ask_one for
> login is unnecessary.
> The `credential_ask_one()` function internally uses `git_prompt()` which
> in case it is given the flag PROMPT_ASKPASS uses masked input method
> instead of git_terminal_prompt, which does not mask user input.
> This fixes https://github.com/git-for-windows/git/issue/675
This link is dead. Is there a more modern URL to which this can point?
> Signed-off-by: Jarosław Honkis <yaras6@xxxxxxxxx>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>