Web lists-archives.com

Re: [PATCH] trace2: fix incorrect function pointer check






On 4/25/2019 1:08 PM, Josh Steadmon wrote:
Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl
in its targets, rather than pfn_data_fl, which is not actually called.

Signed-off-by: Josh Steadmon <steadmon@xxxxxxxxxx>
---
  trace2.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trace2.c b/trace2.c
index 8bbad56887..a73cfdf6fe 100644
--- a/trace2.c
+++ b/trace2.c
@@ -717,7 +717,7 @@ void trace2_data_json_fl(const char *file, int line, const char *category,
  	us_elapsed_region = tr2tls_region_elasped_self(us_now);
for_each_wanted_builtin (j, tgt_j)
-		if (tgt_j->pfn_data_fl)
+		if (tgt_j->pfn_data_json_fl)
  			tgt_j->pfn_data_json_fl(file, line, us_elapsed_absolute,
  						us_elapsed_region, category,
  						repo, key, value);


good catch.  thanks.

Jeff