Re: [PATCH] trace2: fix incorrect function pointer check
- Date: Fri, 26 Apr 2019 11:42:12 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH] trace2: fix incorrect function pointer check
Derrick Stolee <stolee@xxxxxxxxx> writes:
> On 4/25/2019 1:08 PM, Josh Steadmon wrote:
>> Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl
>> in its targets, rather than pfn_data_fl, which is not actually called.
>> for_each_wanted_builtin (j, tgt_j)
>> - if (tgt_j->pfn_data_fl)
>> + if (tgt_j->pfn_data_json_fl)
>> tgt_j->pfn_data_json_fl(file, line, us_elapsed_absolute,
> Seems obviously correct. Thanks!
Thanks, both. It is embarrassing and sad that nobody caught it
before it hit my tree X-<.