Re: [PATCH 1/5] t9350: fix encoding test to actually test reencoding
- Date: Thu, 25 Apr 2019 13:52:23 -0400
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH 1/5] t9350: fix encoding test to actually test reencoding
On Thu, Apr 25, 2019 at 11:51 AM Elijah Newren <newren@xxxxxxxxx> wrote:
> This test used an author with non-ascii characters in the name, but
> no special commit message. It then grep'ed for those non-ascii
> characters, but those are guaranteed to exist regardless of the
> reencoding process since the reencoding only affects the commit message,
> not the author or committer names. As such, the test would work even if
> the re-encoding process simply stripped the commit message entirely.
> Modify the test to actually check that the reencoding in utf-8 worked.
> Signed-off-by: Elijah Newren <newren@xxxxxxxxx>
> diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh
> @@ -94,22 +94,22 @@ test_expect_success 'fast-export --show-original-ids | git fast-import' '
> +test_expect_success 'iso-8859-7' '
> + test_when_finished "git config --unset i18n.commitencoding" &&
> + git config i18n.commitencoding iso-8859-7 &&
Aren't these two lines are pretty much equivalent to this single line?
test_config i18n.commitencoding iso-8859-7 &&