Re: How to undo previously set configuration? (again)
- Date: Thu, 25 Apr 2019 17:27:01 +0200
- From: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
- Subject: Re: How to undo previously set configuration? (again)
On Thu, Apr 25 2019, Barret Rhoden wrote:
> Hi -
> On 4/25/19 10:36 AM, Jonathan Nieder wrote:
>> Ævar Arnfjörð Bjarmason wrote:
>>> Because we don't have some general config facility for this it keeps
>>> coming up, and various existing/proposed options have their own little
>>> custom hacks for doing it, e.g. this for Barret Rhoden's proposed "blame
>>> skip commits" feature
>>> (b.t.w. I*meant* /dev/null in that E-Mail, but due to PEBCAK wrote
>> I'm confused. Isn't that bog-standard Git usage, not a custom hack?
>> That is, I thought the intended behavior is always
>> 1. For single-valued options, last value wins.
>> 2. For multi-valued options, empty clears the list.
>> 3. When there is a special behavior triggered by not supplying the
>> option at all, offer an explicit value like "default" that triggers
>> the same behavior, too.
>> and that any instance of a command that isn't following that is a bug.
> Not sure if it's meant to be the standard, but I just went with the
> style used by credential.helper. This was suggested to me by Johannes
> in :
Just to be clear I'm not picking on your patch, I think doing it that
way makes perfect sense in the current system.
Just as noted upthread using it as an example (that was fresh in my
mind...) of a case where we want this, but it's a bespoke thing for
every use-case, and not consistent (i.e. just supported for your new
thing, but not for the existing fsck code that's mostly the same).
> On 2019-01-18 at 10:47 Johannes Schindelin <Johannes.Schindelin@xxxxxx>
>> A better idea IMHO would be to use an OPT_STRING_LIST() for
>> `--ignore-revs-file`, too, and to allow for multiple
>> `blame.ignoreRevsFile` config entries (with our usual trick of handling an
>> empty setting by resetting the list of paths that were accumulated so
>> far, see e.g. how `credential.helper` is handled).