Re: [PATCH v3 3/6] mergetool: use get_merge_tool function
- Date: Thu, 25 Apr 2019 11:36:01 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH v3 3/6] mergetool: use get_merge_tool function
Denton Liu <liu.denton@xxxxxxxxx> writes:
> This change is not completely backwards compatible as there may be
> external users of git-mergetool--lib. However, only one user,
> git-diffall, was found from searching GitHub and Google. It seems
> very unlikely that there exists an external caller that would take into
> account the return code of `get_merge_tool` as it would always return 0
> before this change so this change probably does not affect any external
Sounds like a risk that is OK to accept, as it is easy enough to
reintroduce the middle layer function like you did in the previous
round when it becomes an issue.
Will queue; thanks.