Re: [PATCH 0/5] Multiple hook support
- Date: Wed, 24 Apr 2019 16:49:54 +0700
- From: Duy Nguyen <pclouds@xxxxxxxxx>
- Subject: Re: [PATCH 0/5] Multiple hook support
On Wed, Apr 24, 2019 at 7:54 AM brian m. carlson
> Oftentimes, people want to use multiple of the same kind of hook. This
> may be because software or a project they use requires a given hook, but
> they would also like to have a custom hook, or because they're using
> multiple pieces of software that both require involvement with the same
Heh you beat me to it. My config-hooks branch  has not been updated
for half a year. I only skimmed through quickly so no useful comments,
but I went with a slightly different design, introducing
for_each_hook() instead (see run-command.[ch] in the last patch).
Back then I wasn't sure what would be the right policy for running
multiple hooks. By keeping the hook loop in one place, we could change
that policy much easier later (e.g. continue anyway in case of
failure, or stop as soon as you see a problem, or even run some
special hooks at the end even when there is an error earlier).
I'm not saying that should be the way to go. Just pointing it out. You
decide. Personally I think open coding the loop is just as well.