Re: jt/fetch-cdn-offload (was What's cooking in git.git (Apr 2019, #04; Mon, 22))
- Date: Tue, 23 Apr 2019 01:34:16 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: jt/fetch-cdn-offload (was What's cooking in git.git (Apr 2019, #04; Mon, 22))
On Mon, Apr 22, 2019 at 10:51:04AM -0700, Jonathan Tan wrote:
> > * jt/fetch-cdn-offload (2019-03-12) 9 commits
> Sorry for getting back to you late on this. The current status is that
> v2 (this version) looks good to me, except that not many people seems to
> be interested in this - I sent out v2  with a relatively significant
> protocol change to v1 (requiring the server to also send the packfile's
> hash, meaning that a workflow that Ævar has described will no longer
> work), but nobody replied to it except for Josh Steadmon (who did give
> his Reviewed-By).
I am interested in this. Sorry to be so slow on reviewing. It's been on
my todo list for a while. I finally gave a look over it and sent some
thoughts. I focused mainly on high-level and design choices, and didn't
look _too_ closely at the code (from what I saw it was all pretty
reasonable, but if you agree with my suggestions there's some re-working
to be done anyway).
FYI, I'll be offline the rest of the week, but I'll try to stay on top
of it next week if you have responses to my comments.