[PATCH v2 0/2] Prepare our git-p4 tests for running on APFS
- Date: Sun, 14 Apr 2019 14:19:28 -0700 (PDT)
- From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx>
- Subject: [PATCH v2 0/2] Prepare our git-p4 tests for running on APFS
Yesterday, the macOS agents of Azure Pipelines were upgraded to Mojave, and
since that does not support HFS+ anymore, everything will be upgraded to
As I just found yesterday, we have one test that fails on that filesystem
(t9822, which is only run if Perforce's p4d is available).
The first patch adds a workaround, as I failed to find any way to finagle
APFS into accepting that ISO-8859-1 encoded file name.
The second patch is a fix to make things compile on Mojave again, apparently
Homebrew changed and the /usr/local/ directories need to be added to the
compiler and linker flags explicitly. Maybe this is a gcc-8 only thing, as
it seems to have affected only the osx-gcc job, not the osx-clang job.
Changes since v1:
* Fix the tyop in the oneline of the first patch where it should talk about
Johannes Schindelin (2):
t9822: skip tests if file names cannot be ISO-8859-1 encoded
macOS: make sure that gettext is found
config.mak.uname | 2 ++
t/t9822-git-p4-path-encoding.sh | 7 +++++++
2 files changed, 9 insertions(+)
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-179/dscho/skip-t9822-on-apfs-v2
Range-diff vs v1:
1: 52681aee0a ! 1: 6161c76702 t9822: skip tests if file names cannot be ISO-8895-1 encoded
@@ -1,6 +1,6 @@
Author: Johannes Schindelin <johannes.schindelin@xxxxxx>
- t9822: skip tests if file names cannot be ISO-8895-1 encoded
+ t9822: skip tests if file names cannot be ISO-8859-1 encoded
Most notably, it seems that macOS' APFS does not allow that.
2: f006524f78 = 2: 25be67b1b7 macOS: make sure that gettext is found