Re: [PATCH] ls-files: use correct format string
- Date: Thu, 11 Apr 2019 00:18:24 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] ls-files: use correct format string
On Sun, Apr 07, 2019 at 07:47:51PM +0100, Thomas Gummerer wrote:
> struct stat_data and struct cache_time both use unsigned ints for all
> their members. However the format string for 'git ls-files --debug'
> currently uses %d for formatting these numbers. This means that we
> potentially print these values incorrectly if they are greater than
> This has been the case since the --debug option was introduced in 'git
> ls-files' in 8497421715 ("ls-files: learn a debugging dump format",
I didn't see any comment on this, but it seems like it must be obviously
correct, since as you note we do define those fields as unsigned. I'm
really surprised that -Wformat doesn't catch this, though. I wonder why.