Web lists-archives.com

Re: [PATCH v2 1/2] transport: warn if server options are unsupported




Jonathan Nieder <jrnieder@xxxxxxxxx> writes:

> Thanks for writing this.  I'd be in favor of making this die().
> Compare what we already do in push:
>
> 	if (args->push_options && !push_options_supported)
> 		die(_("the receiving end does not support push options"));

That's a good point.

> What happens in the case of push with protocol v0, where server options
> are supported?

Are, or are not?

In any case, all other suggestions in your reviews are worth
following up, I would think.  Thanks for a quick review.