Re: [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)
- Date: Tue, 9 Apr 2019 18:19:38 +0200
- From: Torsten Bögershausen <tboegi@xxxxxx>
- Subject: Re: [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)
On 2019-04-09 09:34, Sven Strickroth wrote:
> Am 09.04.2019 um 07:53 schrieb Torsten Bögershausen:
>>> Regression was introduced in commit
>> Was it ?
>> 25d90d1cb merged this commit:
>> 1cadad6f6 (junio/tb/use-common-win32-pathfuncs-on-cygwin)
> Yes, I copied the revision of the merge commit.
>> And, if I read that correctly, 1cadad6f6 does not change anything for MSVC.
>> And the problem with the missing/wrong path resolution was there before
>> 1cadad6f6 and after 1cadad6f6.
> That's not correct, it was correct before:
No, I wasn't aware that msvc.c include mingw.c - for whatever reason.
> 1cadad6f6 removes mingw_offset_1st_component from mingw.c which is
> included by msvc.c. Then the in git-compat.h the new file
> "compat/win32/path-utils.h" is only included for __CYGWIN__ and
> __MINGW32__, here _MSC_VER is missing -> that's the regression.
If possible, I would like to see this kind of information
in the commit message.
Thanks for cleaning up my mess.