Re: [PATCH v5 6/6] RFC blame: use a fingerprint heuristic to match ignored lines
- Date: Mon, 8 Apr 2019 11:48:23 +0200
- From: Michael Platings <michael@xxxxxxxxx>
- Subject: Re: [PATCH v5 6/6] RFC blame: use a fingerprint heuristic to match ignored lines
You also get an out-of-memory error with the patch Barret posted at
the start of this thread.
I'm sorry you interpreted my message as declaring it somebody else's
problem, that definitely wasn't my intent. I merely ran out of time to
investigate further and I figure Barret is going to be interested in
this issue and would prefer that I let him know sooner rather than
(resending in plain text, sorry for the spam again)
On Sun, 7 Apr 2019 at 23:52, David Kastrup <dak@xxxxxxx> wrote:
> michael@xxxxxxxxx writes:
> > From: Michael Platings <michael@xxxxxxxxx>
> > Hi Barret,
> > This is the updated fuzzy matching algorithm, sorry for the delay. It does
> > highlight a bug in the calculation for the number of lines ("int nr_parent_lines
> > = e->num_lines - delta;") - if you apply the patch, build it, then try to
> > ./git blame --ignore-rev <the patch commit ID> blame.c then you'll get a segfault
> > because nr_parent_lines is a negative number. I haven't had time to investigate further
> > but I have confirmed that the bug is not due to my patch.
> If you segfault with the patch and don't segfault with the patch, there
> is not much of a point in declaring this "somebody else's problem", is
> there? It has to be fixed anyway in order to make the patch get in.
> Or am I fundamentally misunderstanding something here?
> David Kastrup