Re: [RFC] TODO in read-cache.c
- Date: Sat, 6 Apr 2019 19:00:26 +0530
- From: Kapil Jain <jkapil.cs@xxxxxxxxx>
- Subject: Re: [RFC] TODO in read-cache.c
On Sat, Apr 6, 2019 at 5:49 PM Duy Nguyen <pclouds@xxxxxxxxx> wrote:
> On Sat, Apr 6, 2019 at 7:14 PM Kapil Jain <jkapil.cs@xxxxxxxxx> wrote:
> > > In some cases, it will be simple. For example, if you have a look at
> > > repo_read_index(), it already knows what repo it handles, so you can
> > > just extend read_index_from() to take 'struct repository *' and pass
> > > 'repo' to it.
> > >
> > > Be careful though, repository and istate does not have one-to-one
> > > relationship (I'll leave it to you to find out why). So you cannot
> > > replace
at a lot of place where, read_index_from() is called, the repo struct
is not available, so i am passing `the_repository` in those calls.
this makes me wonder if this is really required, because most of the
places just don't have repo.