Re: [PATCH v2 1/2] sha1-file: support OBJECT_INFO_FOR_PREFETCH
- Date: Fri, 5 Apr 2019 16:13:24 +0200 (DST)
- From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
- Subject: Re: [PATCH v2 1/2] sha1-file: support OBJECT_INFO_FOR_PREFETCH
On Fri, 29 Mar 2019, Jonathan Tan wrote:
> Teach oid_object_info_extended() to support a new flag that inhibits
> fetching of missing objects. This is equivalent to setting
> fetch_is_missing to 0, calling oid_object_info_extended(), then setting
> fetch_if_missing to whatever it was before. Update unpack-trees.c to use
> this new flag instead of repeatedly setting fetch_if_missing.
> This new flag complicates things slightly in that there are now 2 ways
> to do the same thing.
Just a note that I disagree with the latter part of the sentence: those
are not 2 ways of doing the same thing, but they are two switches that
essentially both have to be flipped to "on". They're just multiple gates.
I do not ask you to rephrase it, merely registering a different opinion.
The patch looks good, I especially like the post-image of
`check_updates()`, which looks much nicer (from my perspective, of