Re: [PATCH 3/5] progress: assemble percentage and counters in a strbuf before printing
- Date: Tue, 26 Mar 2019 01:45:41 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 3/5] progress: assemble percentage and counters in a strbuf before printing
On Mon, Mar 25, 2019 at 11:38:42AM +0100, SZEDER Gábor wrote:
> The following patches in this series want to handle the progress bar's
> title and changing parts (i.e. the counter and the optional percentage
> and throughput combined) differently.
> To prepare for those changes assemble the changing parts in a separate
> strbuf before printing.
Makes sense. Unlike the previous patch, we're already in the "slow path"
of the function here, so we don't need to worry about adding an extra
buffer (though do still think it's worth reusing the same buffer each
time, as you do here).