Web lists-archives.com

Re: [PATCH v1 09/11] t: add tests for restore




Nguyễn Thái Ngọc Duy  <pclouds@xxxxxxxxx> writes:

> diff --git a/t/t2070-restore.sh b/t/t2070-restore.sh
> new file mode 100755
> index 0000000000..df91bf54bc
> --- /dev/null
> +++ b/t/t2070-restore.sh
> @@ -0,0 +1,77 @@
> +#!/bin/sh
> +
> +test_description='restore basic functionality'
> +
> +. ./test-lib.sh
> + ...
> +test_expect_success 'restore -p without pathspec is fine' '
> +	echo q >cmd &&
> +	git restore -p <cmd
> +'

This stands out as a sore thumb, being an invocation with '-p' while
all the other tests for the '-p' feature are in t2071.

Shoudln't it move to somewhere near the beginning of 2071?

> diff --git a/t/t2071-restore-patch.sh b/t/t2071-restore-patch.sh
> new file mode 100755
> index 0000000000..46ebcb2413
> --- /dev/null
> +++ b/t/t2071-restore-patch.sh