Web lists-archives.com

Re: [PATCH] packfile: use extra variable to clarify code in use_pack()




Jeff King <peff@xxxxxxxx> writes:

> I think it does apply, though the reasoning in the commit message of
> "this is OK because 'left' is large enough" becomes a lot more
> hand-wavy. The patch is not making anything _worse_, certainly, but the
> fact of the matter is that "left" still might not be big enough, if it
> is not a size_t.

True; it does not make much sense without the actual size_t
conversion, I would think.