Web lists-archives.com

Re: [RFC/PATCH] point pull requesters to Git Git Gadget




Hi,

On Wed, 13 Mar 2019, Jeff King wrote:

> On Wed, Mar 13, 2019 at 10:49:22AM +0900, Junio C Hamano wrote:
> 
> > Jeff King <peff@xxxxxxxx> writes:
> > 
> > > infrequent contributors. And there are a few reasons to prefer GGG:
> > >
> > >   1. submitGit seems to still have a few rough edges. E.g., it doesn't
> > >      munge timestamps to help threaded mail readers handled out-of-order
> > >      delivery.
> > 
> > Hmph, I had an impression that the recent "why aren't these sorted"
> > topics were via GGG, not submitGit, though.

Hmph. I thought these were sorted out by
https://github.com/gitgitgadget/gitgitgadget/pull/23...

Junio, if you are referring to your complaint in
https://public-inbox.org/git/xmqqftt83bt9.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/,
I just had a look, and the dates of JeffH's 00/14, 01/14 and 02/14 were,
respectively,

Date:   Tue, 22 Jan 2019 13:22:12 -0800 (PST)
Date:   Tue, 22 Jan 2019 13:22:12 -0800 (PST)
and
Date:   Tue, 22 Jan 2019 13:22:14 -0800 (PST)

Not quite what PR #23 tried to achieve. So where does this problem come
from? A little further digging reveals another, quite revealing header:

X-Google-Original-Date: Tue, 22 Jan 2019 21:21:57 GMT
X-Google-Original-Date: Tue, 22 Jan 2019 21:21:58 GMT
and
X-Google-Original-Date: Tue, 22 Jan 2019 21:21:59 GMT

which makes a ton more sense because GitGitGadget would not ever use -0800
as generic timezone.

(to see for yourself, just direct your browser to
https://public-inbox.org/git/pull.108.git.gitgitgadget@xxxxxxxxx/raw
https://public-inbox.org/git/1a90de9dab0dd836e54fee9e08ab9e2284e1027a.1548192131.git.gitgitgadget@xxxxxxxxx/raw
and
https://public-inbox.org/git/4aaf4834bfa9f2169e2c00f7cdc6c75281567c15.1548192131.git.gitgitgadget@xxxxxxxxx/raw)

So the *real* problem is that your GMail developer colleagues, Junio,
decide that GitGitGadget's Date: header is not good enough, and override
it by a less useful version.

:-)

> We did have one case a few months ago, but I think it was since fixed.
> Whereas it cannot be fixed for submitGit without major re-architecting,
> because the mails go out through Amazon SES, which writes its own
> timestamp.
> 
> I could be wrong about GGG being fixed though. I haven't noticed the
> problem lately, but we definitely had a submitGit-related one a few
> weeks ago.

Maybe you use two different versions of mutt?

*ducks* ;-)

I come more and more to the conclusion that you can use whatever mail
client to read the Git mailing list, as long as it is mutt. Which leaves
me behind, as an Alpine (and occasional Thunderbird and Roundcube Mail)
user...

Ciao,
Dscho