Web lists-archives.com

Re: [RFC/PATCH] packfile: use extra variable to clarify code in use_pack()





On 12/03/2019 16:55, Ramsay Jones wrote:
> From: Jeff King <peff@xxxxxxxx>
> 
> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
> Hi Jeff,
> 
> I recently tried (yet again) to tidy up some old branches. When I get
> around to doing a 'git gc; git fsck' I always take a quick look at
> the 'dangling' commits, just before a 'git gc --prune=now'.
> 
> I had no recollection of this commit, from last October, but a quick
> look at the ML archive found this [1] discussion. I obviously thought
> it was worth saving this thought of yours. ;-) So, having deleted this
> already, I did a quick 'format-patch' to see if anyone thinks it is
> worth applying.
> 
> [1] https://public-inbox.org/git/20181013024624.GB15595@xxxxxxxxxxxxxxxxxxxxx/#t
> 

Heh, of course I should have tried applying on top of today's
codebase before sending it out! :(

Having just done so, it quickly showed that this patch assumes
that the 'left' parameter to use_pack() has been changed from
an 'unsigned long *' to an 'size_t *' as part of the series
that was being discussed in the above link.

Ah, well, sorry for the noise!

ATB,
Ramsay Jones