Web lists-archives.com

Re: Solaris and sed: Too many commands, last: s/\n//




On Mon, Mar 11, 2019 at 10:11 PM Jeffrey Walton <noloader@xxxxxxxxx> wrote:
>
> On Mon, Mar 11, 2019 at 9:55 PM Jeffrey Walton <noloader@xxxxxxxxx> wrote:
> >
> > On Mon, Mar 11, 2019 at 9:07 PM Jeffrey Walton <noloader@xxxxxxxxx> wrote:
> > >
> > > On Mon, Mar 11, 2019 at 6:28 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> > > >
> > > > On Mon, Mar 11, 2019 at 05:43:55PM -0400, Jeffrey Walton wrote:
> > > > > On Mon, Mar 11, 2019 at 5:15 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> > > > > > On Mon, Mar 11, 2019 at 4:32 PM Jeffrey Walton <noloader@xxxxxxxxx> wrote:
> > > > > > > I enabled self tests for Solaris. Solaris has some anemic utilities so
> > > > > > > I put /usr/gnu/bin first on-path.
> > > > > >
> > > > > > The first question is if you are really running GNU 'sed'? My guess is
> > > > > > "no, it's still picking up Solaris's 'sed'".
> > > > >
> > > > > I believe so. After modifying PATH, command -v returns:
> > > > >
> > > > >     Solaris tools:
> > > > >          sed: /usr/gnu/bin/sed
> > > > >          awk: /usr/gnu/bin/awk
> > > > >         grep: /usr/gnu/bin/grep
> > > > >
> > > > > (This was added to my scripts to confirm).
> > > > ...
> > > >
> > > > > Maybe Git would benefit from SED, AWK and GREP variables like PERL.
> > > >
> > > > Very possibly.
> > >
> > > Another potential workaround is to use Perl. Perl is already a
> > > prerequisite, it get passed to the test gear through PERL_PATH, and it
> > > avoids Solaris' anemic tools.
> > >
> > > Sadly my Perl sucks. You would be disappointed if I tried to whip up a patch.
> >
> > Oh man, you're using GNU make. I thought Git was using that anemic
> > Posix Make. See attached.
> >
> > I think Solaris provides an older gawk. Is this an easier problem:
> >
> >     awk: chainlint.sed:88: :squash
> >     awk: chainlint.sed:88: ^ syntax error
> >     awk: chainlint.sed:91:  s/\\\n//
> >     awk: chainlint.sed:91:    ^ backslash not last character on line
> >     Usage: awk [POSIX or GNU style options] -f progfile [--] file ...
> >     Usage: awk [POSIX or GNU style options] [--] 'program' file ...
>
> My bad , there was a typo... 'awk' got assigned to SED variable.
>
> This patch works as expected.

https://github.com/git/git/pull/582