Web lists-archives.com

Fwd: [GSoC][PATCH] tests: avoid using pipes




Sorry, I forgot to Cc, again.

---------- Forwarded message ---------
From: ttjtftx <ttjtftx@xxxxxxxxx>
Date: Tue, Mar 12, 2019 at 12:32 AM
Subject: Re: [GSoC][PATCH] tests: avoid using pipes
To: Christian Couder <christian.couder@xxxxxxxxx>


On Sun, Mar 10, 2019 at 11:05 PM Christian Couder
<christian.couder@xxxxxxxxx> wrote:
>
> On Sun, Mar 10, 2019 at 9:28 AM ttjtftx <ttjtftx@xxxxxxxxx> wrote:
> >
> > On Sun, Mar 10, 2019 at 2:06 PM Christian Couder
> > <christian.couder@xxxxxxxxx> wrote:
> >
> > > If you take a look at c6f44e1da5 ("t9813: avoid using pipes",
> > > 2017-01-04) you can see the following:
> > >
> > >     - it changes only one test file: t9813-git-p4-preserve-users.sh
> > >     - its title starts with "t9813: "
> > I adapted this format in my second version[1].
> >
> > [1]: https://public-inbox.org/git/20190310080739.63984-1-ttjtftx@xxxxxxxxx
>
> It's better because each patch changes only one file, but I also
> wanted to say that for a microproject you only need to focus on only
> one file. So I would you suggest you keep only the patches that are
> about "t0000-basic.sh" and drop the patches about
> "t0003-attributes.sh" and "t0022-crlf-rename.sh".

I will do that as I have made too many mistakes. I decided to do more
than one file because
I thought it might be too small even for a microproject and that there
would be more chances
for feedback if I include more files, since the same file tend to have
similar conversions needed.

> It's also a small nit but your patches start with "t0000-basic: " not
> just "t0000: " though the latter format is more frequent in existing
> commits than the former.

Got it.