Re: [PATCH v1 00/11] And new command "restore"
- Date: Mon, 11 Mar 2019 09:01:47 -0700
- From: Elijah Newren <newren@xxxxxxxxx>
- Subject: Re: [PATCH v1 00/11] And new command "restore"
On Sun, Mar 10, 2019 at 4:19 AM Duy Nguyen <pclouds@xxxxxxxxx> wrote:
> On Fri, Mar 8, 2019 at 5:17 PM Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote:
> > - --index has a different meaning in git-apply. I don't have a good
> > suggestion except "yeah we have two different worlds now, the old
> > and the new one"
> I will rename --index to --staged to avoid this. It is already used as
> synonym for --cached in git-diff. I will also add --staged as synonym
> to "git rm" so that "git status" can consistently advise "git <verb>
> --staged" where verb is either restore or rm.
> Since option rename is a lot of work. If you think this is not a good
> move, raise it now, even if it's just "I don't like it, no reasons".
Works for me, but this sounds like the kind of thing Junio might
object to, so I'm curious about his input.