Web lists-archives.com

Fwd: [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes




Sorry, I forgot to Cc.

---------- Forwarded message ---------
From: ttjtftx <ttjtftx@xxxxxxxxx>
Date: Mon, Mar 11, 2019 at 11:43 PM
Subject: Re: [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes
To: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>


On Sun, Mar 10, 2019 at 6:03 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:

> All of the patches in this series are malformed. There should be a
> "---" line right here below your sign-off. The "---" line is
> recognized by git-am/git-apply as separating the commit message from
> the actual diff(s).

I will check it next time.

> It is a very well-established custom in Git tests for the files handed
> to test_cmp() to be named "expect" and "actual", so this change is not
> the most desirable. What you can do instead is:
>
>     git diff-tree -M -r --name-status HEAD^ HEAD >output &&
>     sed -e "s/R[0-9]*/RNUM/" output >actual &&
>
> which allows you to leave the test_cmp() line alone, thus (as a bonus)
> makes the patch less noisy.

Thanks for the tips! Now I see why "actual" is the most used name for
output files.