Re: [PATCH v2] line-log: suppress diff output with "-s"
- Date: Sun, 10 Mar 2019 23:54:33 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH v2] line-log: suppress diff output with "-s"
On Fri, Mar 08, 2019 at 07:44:22PM +0100, Johannes Schindelin wrote:
> > Do we want to do something like this:
> > diff --git a/revision.c b/revision.c
> > index eb8e51bc63..a1b4fe2aa6 100644
> > --- a/revision.c
> > +++ b/revision.c
> > @@ -2689,6 +2689,10 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
> > if (revs->first_parent_only && revs->bisect)
> > die(_("--first-parent is incompatible with --bisect"));
> > + if (revs->line_level_traverse &&
> > + (revs->diffopt.output_format & ~(DIFF_FORMAT_PATCH|DIFF_FORMAT_NO_OUTPUT)))
> > + die(_("-L does not yet support diff formats besides -p and -s"));
> > +
> > if (revs->expand_tabs_in_log < 0)
> > revs->expand_tabs_in_log = revs->expand_tabs_in_log_default;
> Since you already have that patch, why not go wild and apply it, too? ;-)
OK, then. Here it is as a real patch.
> I guess you copy-edited the code from somewhere because you usually do
> leave spaces around the `|`... I don't care, though ;-)
Heh, nope, I wrote it by hand.
I actually wondered if there was a better way to write this. One of the
things that bugs me about the patch is that this policy check is so far
from actual line-log code, which means the two may drift apart over
time. We could put a LINE_LOG_SUPPORTED_FORMATS into line-log.h, but
that's also pretty far from the actual code. We could just make the
output logic in the line-log code something like:
...do no output...
else if (PATCH || DEFAULT)
...show normal patch...
die("unsupported output format");
but it's probably a little friendlier to diagnose the problem up front,
not after we did a bunch of computation. And most of these other
"incompatible" checks in setup_revisions() suffer from the same
maintainability problem. So instead, I went with the code above (with
spaces!) and protected it with some tests.
-- >8 --
Subject: [PATCH] line-log: detect unsupported formats
If you use "log -L" with an output format like "--raw" or "--stat",
we'll silently ignore the format and just output the normal patch.
Let's detect and complain about this, which at least tells the user
what's going on.
The tests here aren't exhaustive over the set of all formats, but it
should at least let us know if somebody breaks the format-checking.
Signed-off-by: Jeff King <peff@xxxxxxxx>
On top of the other patch, naturally.
revision.c | 4 ++++
t/t4211-line-log.sh | 10 ++++++++++
2 files changed, 14 insertions(+)
diff --git a/revision.c b/revision.c
index eb8e51bc63..cb69a227d5 100644
@@ -2689,6 +2689,10 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
if (revs->first_parent_only && revs->bisect)
die(_("--first-parent is incompatible with --bisect"));
+ if (revs->line_level_traverse &&
+ (revs->diffopt.output_format & ~(DIFF_FORMAT_PATCH | DIFF_FORMAT_NO_OUTPUT)))
+ die(_("-L does not yet support diff formats besides -p and -s"));
if (revs->expand_tabs_in_log < 0)
revs->expand_tabs_in_log = revs->expand_tabs_in_log_default;
diff --git a/t/t4211-line-log.sh b/t/t4211-line-log.sh
index c9f2036f68..1db7bd0f59 100755
@@ -122,4 +122,14 @@ test_expect_success '-s shows only line-log commits' '
test_cmp expect actual
+test_expect_success '-p shows the default patch output' '
+ git log -L1,24:b.c >expect &&
+ git log -L1,24:b.c -p >actual &&
+ test_cmp expect actual
+test_expect_success '--raw is forbidden' '
+ test_must_fail git log -L1,24:b.c --raw