Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error
- Date: Sun, 10 Mar 2019 17:59:24 +0000
- From: Thomas Gummerer <t.gummerer@xxxxxxxxx>
- Subject: Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error
On 03/10, Jonathan Chang wrote:
> Thanks for the reviews.
> Here are the changes in the second version:
> - bug fixes
> - add preparatory patch
> - seperate different files to different patch
> - change to use test_line_count in a seperate patch
> Also I found that there is no such function as test_char_count,
> is it worthwile to add such function? Here are some stat:
> `git grep 'test_line_count' | wc -l` = 626
> `git grep 'wc -l' | wc -l` = 294
> `git grep 'wc -c' | wc -l` = 68
I do think it would be helpful to introduce that helper, especially if
it is useful in this patch series. There seem to be enough other
places where it can be useful to make it worth adding the helper.
> -- >8 --
> This is a preparatory step prior to removing the pipes after git
> commands, which discards git's exit code and may mask a crash.
The commit message should also describe why we need this preparatory
step. Maybe something like:
To reduce the noise in when refactoring this pipeline in a
subsequent commit fix the indentation. This has been wrong
since the refactoring done in 1b5b2b641a ("t0000: modernise
style", 2012-03-02), but carries no meaning.
> Signed-off-by: Jonathan Chang <ttjtftx@xxxxxxxxx>
Out of curiosity, how did you create the patch? 'git format-patch'
would add a '---' line followed by the diffstat, where you would
usually put the commentary that you put before the scissors line. It
seems like 'git am' still handles this fine, which I didn't know, just
something I noticed because I'm used to the other format.
Since this patch series is now 5 patches, that commentary should go
into a cover letter (see the --cover-letter option in format-patch),
so the reviewers can read that first, and read the patches with that
in mind, focusing on the patch only, and not additional commentary
that applies to the whole series when reading the patch.
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> index b6566003dd..53821f5817 100755
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -1132,7 +1132,7 @@ test_expect_success 'git commit-tree records the correct parent in a commit' '
> test_expect_success 'git commit-tree omits duplicated parent in a commit' '
> commit2=$(echo NO | git commit-tree $P -p $commit0 -p $commit0) &&
> - parent=$(git show --pretty=raw $commit2 |
> + parent=$(git show --pretty=raw $commit2 |
> sed -n -e "s/^parent //p" -e "/^author /q" |
> sort -u) &&
> test "z$commit0" = "z$parent" &&