Re: [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes
- Date: Sun, 10 Mar 2019 06:03:31 -0400
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes
On Sun, Mar 10, 2019 at 4:10 AM Jonathan Chang <ttjtftx@xxxxxxxxx> wrote:
> The exit code of the upstream in a pipe is ignored thus we should avoid
> using it. By writing out the output of the git command to a file, we can
> test the exit codes of both the commands.
> Signed-off-by: Jonathan Chang <ttjtftx@xxxxxxxxx>
All of the patches in this series are malformed. There should be a
"---" line right here below your sign-off. The "---" line is
recognized by git-am/git-apply as separating the commit message from
the actual diff(s).
> diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh
> @@ -23,10 +23,10 @@ test_expect_success setup '
> test_expect_success 'diff -M' '
> - git diff-tree -M -r --name-status HEAD^ HEAD |
> - sed -e "s/R[0-9]*/RNUM/" >actual &&
> + git diff-tree -M -r --name-status HEAD^ HEAD >actual &&
> + sed -e "s/R[0-9]*/RNUM/" actual >output &&
> echo "RNUM sample elpmas" >expect &&
> - test_cmp expect actual
> + test_cmp expect output
It is a very well-established custom in Git tests for the files handed
to test_cmp() to be named "expect" and "actual", so this change is not
the most desirable. What you can do instead is:
git diff-tree -M -r --name-status HEAD^ HEAD >output &&
sed -e "s/R[0-9]*/RNUM/" output >actual &&
which allows you to leave the test_cmp() line alone, thus (as a bonus)
makes the patch less noisy.