Re: [PATCH v1 02/11] restore: take tree-ish from --source option instead
- Date: Sun, 10 Mar 2019 03:58:54 -0400
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH v1 02/11] restore: take tree-ish from --source option instead
On Fri, Mar 8, 2019 at 5:17 AM Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote:
> This is another departure from 'git checkout' syntax, which uses -- to
> separate ref and pathspec. The observation is restore (or "git
> checkout ,, <pathspec>") is most often used to restore some files from
What is the ",," thing?
> the index. If this is correct, we can simplify it by taking a way the
> ref, so that we can write
> git restore some-file
> without worrying about some-file being a ref and whether we need to do
> git restore -- some-file
> for safety. If the source of the restore comes from a tree, it will be
> in the form of an option with value, e.g.
> git restore --source=this-tree some-file
> This is of course longer to type than using "--". But hopefully it
> will not be used as often, and it is clearly easier to understand.
> dwim_new_local_branch is no longer set (or unset) in cmd_restore_files()
> because it's irrelevant because we don't really care about dwim-ing.
> With accept_ref being unset, dwim can't happen.
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>