Re: [PATCH 0/2] stash: handle pathspec magic again
- Date: Sun, 10 Mar 2019 09:56:51 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH 0/2] stash: handle pathspec magic again
Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> If you care deeply about the commit history, I hereby offer to you to
> clean up the built-in stash patches when you say you're ready to advance
> them to `master`.
What's the goal of such a rebase? To rebuild the topic as a
sensible sequence of commits that logically builds on top of
previous steps to ease later bisection and understanding?
Thanks for an offer out of good intentions,, but let's move on and
polish the tree shape at the tip of this topic. The history behind
it may be messier than other segments of our history, and future
developers may have harder time learning the intention of the topic
when making changes on top, but this one was supposed to create a
bug-to-bug reimplementation of the scripted version. What matters
more would be our future changes on top of this code, which improves
what we used to have as scripted Porcelain. They will genuinely be
novel efforts, need to be built in logical order and explainable
steps to help future developers. Compared to that, so the history
of our stumbling along the way to reach today's tip of the topic
has much lower value.
Besides I think it is way too late for the current topic. We
established before the topic hit 'next' that reviewers' eyes all
lost freshness and patience to review another round of this series
We at least know that the ordering and organization of the iteration
we see in 'next' is crappy, because some reviewers did look at them.
The rewrite will see no reviews, if any, far fewer and shallower
reviews than the iteration we have; nobody would be able to say with
confidence that the rewritten series achieves its goal of leaving a
sensible history. Doing so just before it hits 'master' makes it a
Let's just we all admit that we did a poor job when we decided to
push this topic to 'next' before it was ready, and learn the lesson
to avoid haste making waste for the future topics.