Re: [PATCH v1 10/11] completion: support restore
- Date: Sat, 9 Mar 2019 11:16:59 -0800
- From: Elijah Newren <newren@xxxxxxxxx>
- Subject: Re: [PATCH v1 10/11] completion: support restore
On Fri, Mar 8, 2019 at 2:17 AM Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote:
> Completion for restore is straightforward. We could still do better
> though by give the list of just tracked files instead of all present
> ones. But let's leave it for later.
I'm slightly worried that due to using --no-overlay mode by default in
restore, having tab-completion include untracked files increases the
risk of accidentally nuking the wrong file. restore is a destructive
command anyway and should thus be used with care, so perhaps this
isn't a big deal, but I thought I'd mention it.