Re: [PATCH v4] commit-tree: utilize parse-options api
- Date: Wed, 6 Mar 2019 21:52:55 -0400
- From: Brandon Richardson <brandon1024.br@xxxxxxxxx>
- Subject: Re: [PATCH v4] commit-tree: utilize parse-options api
On Wed, Mar 6, 2019 at 7:21 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
> > +When mixing `-m` and `-F` options, the commit log message will be
> > +composed in the order in which the options are given.
> It may be just me, but this new paragraph made me think that we can
> give at most one -m and one -F option at the same time in any order,
> and multiple -m or -F options are not supported. That, obviously,
> is not the impression we want to give to the readers.
> Even when you are not mixing -m and -F, but using -m more than once,
> the log message will be composed in the order in which options are
> given. So probably the word "mixing" is the primary culprit of
> making the sentence easier to be misunderstood.
> When using more than one `-m` or `-F` options, ...
Good call, 'mixing' is not the right word here. Will fix.
> The change to this main function looks quite straight-forward. I am
> kind of surprised that a very low hanging fruit like this had survived
> without getting hit by parseopt a lot earlier ;-)
I was surprised too, commit-tree hasn't seen much love over the years.
There are certainly others that could benefit from parse-options.