Re: [PATCH] builtin/config.c: don't print a newline with --color
- Date: Wed, 6 Mar 2019 15:44:49 -0800
- From: Taylor Blau <me@xxxxxxxxxxxx>
- Subject: Re: [PATCH] builtin/config.c: don't print a newline with --color
On Sat, Mar 02, 2019 at 09:25:28PM +0100, Johannes Schindelin wrote:
> Hi Taylor,
> On Fri, 1 Mar 2019, Taylor Blau wrote:
> > [ ... ]
> This should do the right thing if you write
> printf "<RED>" >expect
> > + printf "\\033[31m" >expect &&
> > + git config --get --type=color foo.color >actual &&
> > test_cmp expect actual
> > '
> > --
> > 2.20.1
Thank you for your suggestion. It occurred to me that this might be a
preferable way to do things after I sent the patch, but I am glad
that you suggested it here explicitly.
That said, I think that this patch has moved on from the code change,
after some discussion between Junio and Peff, so I think that I will
leave this (and the rest of the code changes) behind.
 ... preferable in the way that we don't have to write "\\033[31m" in