Web lists-archives.com

Re: [PATCH 0/1] remote-curl: mark all error messages for translation




Hi Junio,

On Wed, 6 Mar 2019, Junio C Hamano wrote:

> Junio C Hamano <gitster@xxxxxxxxx> writes:
> 
> > "Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx>
> > writes:
> >
> >> As suggested by Jeff King in a nearby thread.
> >>
> >> Johannes Schindelin (1):
> >>   remote-curl: mark all error messages for translation
> >
> > Does this come on top or below the anonymize patch, or it does not
> > matter which goes first?
> 
> OK, will pile on top of the anonymization thing.

Sorry, yes, it is on top of the anonymization thing. I was assuming by
mistake that GitGitGadget would display in the footer on which branch the
PR is based, but it only has the commit hash of the "based-on" commit.

BTW I was expecting the merge conflicts you ran into, that's why I kept
this patch separate from the anonymization thing.

Ciao,
Dscho

> 
> Thanks.
> 
> >
> >>
> >>  remote-curl.c | 50 +++++++++++++++++++++++++-------------------------
> >>  1 file changed, 25 insertions(+), 25 deletions(-)
> >>
> >>
> >> base-commit: c1284b21f2436de24c9559fcc5f4badb04f47773
> >> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-157%2Fdscho%2Fl10n-remote-curl-diag-v1
> >> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-157/dscho/l10n-remote-curl-diag-v1
> >> Pull-Request: https://github.com/gitgitgadget/git/pull/157
>