Web lists-archives.com

Re: [PATCH 1/1] curl: anonymize URLs in error messages and warnings




Hi Peff,

On Tue, 5 Mar 2019, Jeff King wrote:

> On Mon, Mar 04, 2019 at 07:33:46AM -0800, Johannes Schindelin via GitGitGadget wrote:
> 
> > @@ -442,17 +443,23 @@ static struct discovery *discover_refs(const char *service, int for_push)
> >  		break;
> >  	case HTTP_MISSING_TARGET:
> >  		show_http_message(&type, &charset, &buffer);
> > -		die("repository '%s' not found", url.buf);
> > +		die("repository '%s' not found",
> > +		    transport_anonymize_url(url.buf));
> 
> Sort of orthogonal to your patch, but these could probably stand to be
> marked for translation (I'm happy for that to come on top later,
> though).

Good idea!

Ciao,
Dscho