Web lists-archives.com

Re: [PATCH 16/20] diff-parseopt: convert --quiet




On Tue, Mar 5, 2019 at 7:32 AM Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote:
> diff --git a/diff.c b/diff.c
> @@ -5299,6 +5299,8 @@ static void prep_parse_options(struct diff_options *options)
> +               OPT_BOOL(0, "quiet", &options->flags.quick,
> +                        N_("disable all output of the program")),

As a reviewer, I was wondering why you didn't use OPT__QUIET() here, but...

> @@ -5348,9 +5350,7 @@ int diff_opt_parse(struct diff_options *options,
> -       } else if (!strcmp(arg, "--quiet"))
> -               options->flags.quick = 1;
> -       else if (!strcmp(arg, "--ext-diff"))

I guess the reason is that flags.quick isn't necessarily about
verbosity/quietness.