Web lists-archives.com

Re: [GSoC][PATCH v3 3/3] t3600: use helpers to replace test -d/f/e/s <path>




On Tue, Mar 5, 2019 at 8:43 AM Rohit Ashiwal <rohit.ashiwal265@xxxxxxxxx> wrote:
> On 2019-03-05 0:42 Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> > As with the commit message of 2/3, many of the words in this message
> > are separated by multiple spaced. Please fold out the excess so there
> > is only a single space between words.
> >
> > Also, no need to say "previously" since readers know that the patch is
> > changing something. Rewrite in imperative mood:
>
> Okay, I'll keep that in mind from next time onwards. The spaces were
> provided to make the commit message look aesthetically pleasing.
>
> These changes aside, is there anything you would like to add to the review?
> or is it good to go for a merge?

I don't understand your question.