Web lists-archives.com

Re: [PATCH 1/1] Makefile: use `git ls-files` to list header files, if possible




On Sat, Mar 02, 2019 at 08:54:55PM +0100, Johannes Schindelin wrote:

> On Fri, 1 Mar 2019, Jeff King wrote:
> 
> > On Fri, Mar 01, 2019 at 04:54:15PM -0500, Jeff King wrote:
> > 
> > > The one thing we do lose, though, is make's parallelization. It would
> > > probably be possible to actually shove this into a sub-make which
> > > defined the hdr-check rules, but I don't know how complicated that would
> > > become.
> > 
> > This seems to work, though it's kind of horrid.
> > 
> > It costs at least one extra process to run "make hdr-check", and
> > probably more for things like $(GIT_VERSION) that the Makefile include
> > likely triggers. But when you're not running hdr-check (which is the
> > norm), it's zero-cost.
> 
> If we want to go that route (and I am not saying we should), we could
> easily just add another target (say, `check-headers`) that requires a list
> of headers to check to be passed in via a Makefile variable that is
> defined via the command-line.

Yeah, that was actually going to be my initial attempt before I tried
the "include" shortcut. :) I'd worry slightly about things like
command-line limits, but maybe our list isn't big enough to justify
that.

-Peff