Re: [BUG] completion.commands does not remove multiple commands
- Date: Sat, 2 Mar 2019 08:08:59 +0700
- From: Duy Nguyen <pclouds@xxxxxxxxx>
- Subject: Re: [BUG] completion.commands does not remove multiple commands
On Sat, Mar 2, 2019 at 6:08 AM Jeff King <peff@xxxxxxxx> wrote:
> On Fri, Mar 01, 2019 at 05:15:51PM -0500, Todd Zullinger wrote:
> > Hmm. The comments in list_cmds_by_config() made me wonder
> > if not using a local repo config was intentional:
> > /*
> > * There's no actual repository setup at this point (and even
> > * if there is, we don't really care; only global config
> > * matters). If we accidentally set up a repository, it's ok
> > * too since the caller (git --list-cmds=) should exit shortly
> > * anyway.
> > */
> Well, let's see what Duy says. :)
I vaguely recall that I wanted to cache the results in
git-completion.bash at some point. But looking at that script I don't
think there's any caching. So yes it should be ok to read per-repo
config as well (and adjust or drop this comment block)
> I've never used completion.commands myself, but it seems reasonable that
> somebody might want different completion in different repos (e.g., if
> they never use "mergetool" in one repo, but do in another).
It sounds to me confusing that you want different command sets in
different repos. Which is why I made it global config only. But I
suspect that people who have per-repo aliases may find this natural.
So yeah, no objection.
PS. and thanks for the bug fix.