Re: [RFC PATCH 1/4] name-rev: improve name_rev() memory usage
- Date: Fri, 1 Mar 2019 13:00:01 -0500
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [RFC PATCH 1/4] name-rev: improve name_rev() memory usage
On Fri, Mar 1, 2019 at 12:50 PM Alban Gruin <alban.gruin@xxxxxxxxx> wrote:
> There a condition that will always be false here when name_rev() calls
> itself for the first parent, but it will become useful when name_rev()
> will stop to name commits that are not mentionned in the stdin buffer.
> If the current commit should not be named, its parents may have to be,
> but they may not. In this case, name_rev() will tell to its caller that
> the current commit and its first parent has not used the name, and that
> it can be released. However, if the current commit has been named but
> not its parent, or the reverse, the name will not be released.
> Signed-off-by: Alban Gruin <alban.gruin@xxxxxxxxx>