Re: [BUG] completion.commands does not remove multiple commands
- Date: Fri, 1 Mar 2019 00:05:17 +0100
- From: SZEDER Gábor <szeder.dev@xxxxxxxxx>
- Subject: Re: [BUG] completion.commands does not remove multiple commands
On Thu, Feb 28, 2019 at 05:31:23PM -0500, Todd Zullinger wrote:
> I was playing with the completion.commands config added in
> 6532f3740b ("completion: allow to customize the completable
> command list", 2018-05-20) and noticed an issue removing
> multiple commands.
> I wanted to remove completion for cherry and mergetool, so I
> added them both to the config:
> git config completion.commands "-cherry -mergetool"
> But git still completes cherry in this case, only removing
> mergetool. Swapping the items in the config yields the
> opposite result (cherry is removed and mergetool is not).
> With luck this will be a clear and easily resolved issue in
> list_cmds_by_config() (in help.c).
Indeed, this seems to fix it for me:
diff --git a/help.c b/help.c
index 520c9080e8..f2c6f0c9f7 100644
@@ -393,8 +393,8 @@ void list_cmds_by_config(struct string_list *list)
const char *p = strchrnul(cmd_list, ' ');
strbuf_add(&sb, cmd_list, p - cmd_list);
- if (*cmd_list == '-')
- string_list_remove(list, cmd_list + 1, 0);
+ if (*sb.buf == '-')
+ string_list_remove(list, sb.buf + 1, 0);