Web lists-archives.com

Re: [PATCH] commit-tree: utilize parse-options api




Hi Andrei,

> > would attempt to translate the option as a tree oid.It was also
>
> Missing space after period.

Oops, thanks for pointing that out.

>
> > +             { OPTION_CALLBACK, 'p', NULL, &parents, "parent",
> > +               N_("id of a parent commit object"), PARSE_OPT_NONEG,
>
> Comparing to other similar places, a single tab should be used to
> align "N_" instead of two spaces.

I've seen a mix of both conventions scattered around, and wasn't sure which
to stick to. I'll switch to that.

Thanks for your comments :-)