[Proposed Fix] daemon.c: not initializing revents
- Date: Sat, 9 Feb 2019 14:56:55 -0500
- From: "Randall S. Becker" <rsbecker@xxxxxxxxxxxxx>
- Subject: [Proposed Fix] daemon.c: not initializing revents
I found this while trying to track down a hang in t5562 - this isn't the
fix, but here it is something that could be considered a code-inspection. If
there have been random unexplained hangs when git runs as a daemon, this
might be the cause.
According to many systems (other than Linux), the revents field is supposed
to be 0 on return to poll(). This was the cause of some heart-ache a while
back in compat/poll/poll.c. I am not certain whether that copy of poll() is
used in daemon, but I wanted to point out that the value is being returned
to poll, outside of compat/poll/poll.c and may present a potential for poll
returning an error on that FD due to random values that might be in revents.
Please see 61b2a1acaae for a related change/justification.
diff --git a/daemon.c b/daemon.c
index 9d2e0d20ef..1e275fc8b3 100644
@@ -1194,6 +1194,7 @@ static int service_loop(struct socketlist *socklist)
handle(incoming, &ss.sa, sslen);
+ pfd[i].revents = 0;